Catalyzed by lewis acid such as AlCl3, CuCl2 and FeCl3, An efficient method for synthesizing quinoline-2,4-dicarboxylate compounds was developed via a one-pot reaction of substituted aromatic amines, ethyl glyoxylate and methyl pyruvate. The major products were separated and purified by thin-layer chromatography, and their structures were characterized by FT-IR, 1H NMR, 13C NMR and elemental analysis. The reaction mechanism and the influence of substituents attached to aromatic amine for the reaction were discussed, which will provide a useful reference for molecular design and synthesis of this kind of novel compounds in the future. This method has some advantages such as cheap materials, mild reaction conditions, high atom economy and high yield.